On Mon, 20 Apr 2009, Lorne Applebaum wrote: > Here's an update of my ALSA patch. It has a few changes: > - Fixed a bug which probably made it not work on a lot (if not most) systems > - Made the ALSA control read-only by default since a lot of volume > button handlers have a bad habit of trying to change the volume. This > can be changed by a module parameter > - Added a kernel config option and code guards. Thank you, it came in at a good time. I will have a serious look at it soon. One thing you can do to help me merge and test it faster, is to make sure it applies and works on top of branch release/2.6.28 of the git trees at: http://repo.or.cz/w/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git (git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git release/2.6.28) because that's what matches the kernel I am running right now. > Still To Do (need help with): > - volume_alsa_notify_change() is not called when the buttons are push. > I'm not sure how to put it into the new hotkey code. I can do that part, don't worry. > - Maybe something should be done about the default hotkey mask so that > the volume buttons can be used. Yes. We will have to always enable them on the firmware to get events for volume_alsa_notify_change(), but let them get through to userspace and the input device only when userspace requested it on the hotkey_mask bitmask. I will take care of this, it is hairy stuff that will touch a lot of not-that-obvious code. > I'm not sure why my last patches didn't get any comments. Were they > that bad? Please let me know if this patch is also horrible. No, I was just overworked and it slipped through the cracks. I was also hoping to break out the driver into multiple files and modules, so that we could follow the ALSA module parameter API without worries, and because of that I kept delaying a serious look on your patch because of that. I will add the ALSA volumer mixer one way or the other soon, might just as well be your code, and might just as well break as much of the ALSA module paramenter API as required to get it to work. We can always fix that later. There are only two things fighting for my attention right now: your ALSA mixer work, and the rfkill rewrite upstream which I need to send patches for thinkpad-acpi to work with or I will cause problems for a lot of people. This means we will have the alsa mixer ready and merged into a sf.net release within two months tops (but likely it will be closer to three weeks :p), and sent upstream for 2.6.31. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
