Re: [PATCH] Fwd: Re: /proc/acpi/ibm/volume broken on X20 since 2.6.22

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Freitag 27 Juli 2007 18:41 schrieb Henrique de Moraes Holschuh:
> This patch is against which version of thinkpad-acpi?  The one in 2.6.21?
>
> Also, next time please use diff -up to create the patch.

Was against 2.6.22, but forget the patch. I tried changing the volume using
/proc/acpi/ibm/volume while playing music, and nothing happens. So my patch
only discarded the errors and don't helps against the real problem.

> > --- 2743,2750 ----
> >   	cmos_cmd = value > current_value ? TP_CMOS_BRIGHTNESS_UP :
> > TP_CMOS_BRIGHTNESS_DOWN; inc = value > current_value ? 1 : -1;
> >   	for (i = current_value; i != value; i += inc) {
> > ! 		if (issue_thinkpad_cmos_command(cmos_cmd) &&
> > ! 		    !acpi_ec_write(brightness_offset, i + inc))
> >   			return -EIO;
> >   	}
>
> This doesn't make sense. issue_thinkpad_cmos_command returns 0 (false) if
> it works.  The way you made it, it seems to imply that the X20 needs *only*
> the CMOS commands, and that it doesn't want the EC writes.

Ok , I see my mistake, but it works. Don't know why. Next thing I dont 
understand: there is no /proc/acpi/ibm/cmos file? But cmos commands require 
this (or not?)

> What happens if you use the ecdump facility to control the volume like
> this: (thinkpad-acpi loaded with experimental=1):
>
> echo 0x30 0x01 > /proc/acpi/ibm/ecdump  (set volume to 1, mute off)
> echo 0x30 0x07 > /proc/acpi/ibm/ecdump  (set volume to 7, mute off)
> echo 0x30 0x45 > /proc/acpi/ibm/ecdump  (set volume to 5, mute ON)
> ...
> etc?
>
> Does it work?  Does it error out with an -EIO ?

Doing this, there is no error, but also nothing happens. I can read the value 
afterwards from /proc/acpi/ibm/volume, but it doesn't reflects the
real value (e.g. it says mute, but i can hear sounds from the speaker)

-- 
gnuPG keyid: 8C2BAF51
fingerprint: 28EE 8438 E688 D992 3661 C753 90B3 BAAA 8C2B AF51

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[Index of Archives]     [Linux ACPI]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Photo]     [Yosemite Photos]     [Yosemite Advice]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux