This patch is against which version of thinkpad-acpi? The one in 2.6.21?
Also, next time please use diff -up to create the patch.
> --- 2743,2750 ----
> cmos_cmd = value > current_value ? TP_CMOS_BRIGHTNESS_UP : TP_CMOS_BRIGHTNESS_DOWN;
> inc = value > current_value ? 1 : -1;
> for (i = current_value; i != value; i += inc) {
> ! if (issue_thinkpad_cmos_command(cmos_cmd) &&
> ! !acpi_ec_write(brightness_offset, i + inc))
> return -EIO;
> }
This doesn't make sense. issue_thinkpad_cmos_command returns 0 (false) if it
works. The way you made it, it seems to imply that the X20 needs *only* the
CMOS commands, and that it doesn't want the EC writes.
So far so good, but if that's how it should be done in the X20, that means
it needs a fix akin to the one I did for brightness, which lets you select
EC, CMOS NVRAM, or both for brightness control.
What happens if you use the ecdump facility to control the volume like this:
(thinkpad-acpi loaded with experimental=1):
echo 0x30 0x01 > /proc/acpi/ibm/ecdump (set volume to 1, mute off)
echo 0x30 0x07 > /proc/acpi/ibm/ecdump (set volume to 7, mute off)
echo 0x30 0x45 > /proc/acpi/ibm/ecdump (set volume to 5, mute ON)
...
etc?
Does it work? Does it error out with an -EIO ?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
