On Sat, 07 Jul 2007, Alfredo Matos wrote:
>
> + if (brightness_mode & 1) {
> + if (!acpi_ec_read(brightness_offset, &level))
> + return -EIO;
> + lnvram &= 7;
> + level = lnvram;
> + };
>
> Shouldn't the previous be something like:
>
> + if (brightness_mode & 1) {
> + if (!acpi_ec_read(brightness_offset, &lnvram))
> + return -EIO;
> + lnvram &= 7;
> + level = lnvram;
> + }
Good cacth! Yes, that means mode 3 and mode 1 are broken in the patch. I
will fix and resend.
> And maybe exchange the names ? Brightness mode 1 is performing the
> ec_read from cmos, while lnvram looks at 0x5e from /dev/nvram right ?
Correct.
> Meanwhile i'm raising a red flag on the fan support in 2.6.22. It
> doesn't allow writing to proc anymore. But i'll raise this on another
> thread.
Ok.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
