Re: [PATCH] systemd: settle should not block basic.target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 6, 2011 at 15:38, Tom Gundersen <teg@xxxxxxx> wrote:
> On machines using lvm, the lvm service must pull in
> udev-settle.service. However,
> most other services don't need to wait for udev to settle. By removing
> Before=basic.target
> from udev-settle.service I can speed up boot on my machine by about two seconds.

Yeah, the current idea is that _if_ something pulls it in, we want to
make sure it's done in basic.target. If the service is not pulled-in,
it will not be started at all, regardless of the basic.target sorting
or not.

It might not be needed, but we thought we would be safer to let it
block basic.target. If that thing runs on your system, you are in
legacy mode anyway. :)

> A side-effect of this is that it no longer makes sense to enable
> udev-settle unconditionally.

We don't do this. The section in the service file only allows:
  systemctl enable foo
to work, it does not enable anything by default. This section is just
nice to have, in case someone needs to enable it unconditionally, but
nothing should ever do that without need.

> However, it would anyway be a bad idea for a service to assume
> udev-settle to be enabled,

Right.

> so all services that needs to wait for settle (such as lvm and sysv
> compat units) should
> anyway make this explicit.

Yeah, they should pull i tin, then it will be started, if they don't,
systemd will not even see the file.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux