[PATCH] systemd: settle should not block basic.target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi guys,

On machines using lvm, the lvm service must pull in
udev-settle.service. However,
most other services don't need to wait for udev to settle. By removing
Before=basic.target
from udev-settle.service I can speed up boot on my machine by about two seconds.

A side-effect of this is that it no longer makes sense to enable
udev-settle unconditionally.
However, it would anyway be a bad idea for a service to assume
udev-settle to be enabled,
so all services that needs to wait for settle (such as lvm and sysv
compat units) should
anyway make this explicit.

What do you think?

Cheers,

Tom

>From cd8413fa7defa94b7e6fa093626a142bb2788391 Mon Sep 17 00:00:00 2001
From: Tom Gundersen <teg@xxxxxxx>
Date: Fri, 6 May 2011 15:19:08 +0200
Subject: [PATCH] settle: do not block basic.target

Some services (such as lvm) stil need to wait for udev to settle. However, there
is no need for all other services also to be blocked.

This means that it is no longer possible to enable udev-settle.service
unconditionally,
but every service that needs it must depend on it explicitly.

Signed-off-by: Tom Gundersen <teg@xxxxxxx>
---
 init/udev-settle.service.in |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/init/udev-settle.service.in b/init/udev-settle.service.in
index d7d6f78..cb89b4d 100644
--- a/init/udev-settle.service.in
+++ b/init/udev-settle.service.in
@@ -13,13 +13,9 @@ Description=udev Wait for Complete Device Initialization
 DefaultDependencies=no
 Requires=udev.service
 After=udev-trigger.service
-Before=basic.target

 [Service]
 Type=oneshot
 TimeoutSec=180
 RemainAfterExit=yes
 ExecStart=@sbindir@/udevadm settle
-
-[Install]
-WantedBy=basic.target
-- 
1.7.5.1
--
To unsubscribe from this list: send the line "unsubscribe linux-hotplug" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Linux DVB]     [Asterisk Internet PBX]     [DCCP]     [Netdev]     [X.org]     [Util Linux NG]     [Fedora Women]     [ALSA Devel]     [Linux USB]

  Powered by Linux