On Mon, Dec 23, 2024 at 04:55:42PM +0000, Arnon Meydav wrote:
> > > diff --git a/wpa_supplicant/config_ssid.h b/wpa_supplicant/config_ssid.h
> > > @@ -1192,6 +1192,13 @@ struct wpa_ssid {
> > > + u16 multi_ap_primary_vlanid;
> >
> > Why would this be added as a new configuration parameter for the network
> > profile? This does not seem to have anything to do with local
> > configuration, i.e., this is a value that shows up as a part of a
> > backhaul association.
>
> We wanted to keep the multi_ap information adjacent to the network information, since this is part of the link definition.
> However, as you rightly pointed out, this is retrieved dynamically from the AP, and not configured in the wpa_supplicant configuration.
> Reviewing the code again, perhaps this should be added directly in struct wpa_supplicant?
> Do you agree, or is there a more suitable location for such information to remain persistent throughout the connection?
Yes, struct wpa_supplicant would be a better place for this type of
information that applies for the current association and is learned
during the association and needed a bit later (i.e., cannot be sent out
in an event directly at the time of reception and instead, needs to be
kept somewhere in memory between that point and the time it is used).
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
