On Wed, Nov 13, 2024 at 07:52:58AM +0000, Arnon Meydav wrote:
> Is there any feedback on this patch?
> Upper layers (e.g. Easymesh agent in a repeater) may need to know the VLAN ID of the backhaul AP, hence we would like to add this information to WPA_EVENT_CONNECTED.
It would seem fine to add such information into the event or some other
convenient location for fetching it (like STATUS command). However, this
commit message and the proposed changed feel a bit confusing if this is
just about reporting the value to upper layers.
> For Multi-AP traffic separation requirement, wpa_supplicant parses 802.1Q Multi-AP sub-element and reports:
> - VLAN ID of the AP it connects to.
> - Multi-AP profile of the AP it connects to.
It would be good to be clear here on why this is being added (i.e., what
the information is used for) and that this is just for reporting and not
changing some configuration parameters.
> diff --git a/wpa_supplicant/config_ssid.h b/wpa_supplicant/config_ssid.h
> @@ -1192,6 +1192,13 @@ struct wpa_ssid {
> + /**
> + * multi_ap_primary_vlanid - Multi-AP Primary VLAN ID (Multi-AP Specification v2.0)
> + * 0 = VLAN ID not set
> + * 1-4094 = VLAN ID
> + */
> + u16 multi_ap_primary_vlanid;
Why would this be added as a new configuration parameter for the network
profile? This does not seem to have anything to do with local
configuration, i.e., this is a value that shows up as a part of a
backhaul association.
> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c
> @@ -1114,11 +1114,14 @@ void wpa_supplicant_set_state(struct wpa_supplicant *wpa_s,
>
> #if defined(CONFIG_CTRL_IFACE) || !defined(CONFIG_NO_STDOUT_DEBUG)
> wpa_msg(wpa_s, MSG_INFO, WPA_EVENT_CONNECTED "- Connection to "
> - MACSTR " completed [id=%d id_str=%s%s]%s",
> + MACSTR " completed [id=%d id_str=%s%s]%s"
> + " multi_ap_profile=%d multi_ap_primary_vlanid=%d",
> MAC2STR(wpa_s->bssid),
> ssid ? ssid->id : -1,
> ssid && ssid->id_str ? ssid->id_str : "",
> - fils_hlp_sent ? " FILS_HLP_SENT" : "", mld_addr);
> + fils_hlp_sent ? " FILS_HLP_SENT" : "", mld_addr,
> + ssid ? ssid->multi_ap_profile : 0,
> + ssid ? ssid->multi_ap_primary_vlanid : 0);
I would prefer to extend the CTRL-EVENT-CONNECTED event to include
these new values only if the association is for Wi-Fi EasyMesh backhaul
connection. This event is used by many external programs and it is
better to try to minimize risk of confusing them in cases where the
association has nothing to do with Wi-Fi EasyMesh.
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
