Am 06.01.20 um 10:22 schrieb Jouni Malinen:
On Sat, Jan 04, 2020 at 11:10:07PM +0100, Alexander Wetzel wrote:
Migrate all remaining drivers from set_tx to the key_flag API.
This patch assumes that the drivers are only using set_tx to handle
default non-pairwise keys as it was intended and don't need it to be set
for pairwise and/or group keys which are RX only.
Maybe this and removal of set_tx from the set_key() params struct should
be postponed until that assumption can actually be shown to be correct?
It does not look like either of these are really needed to be able to
address the real functional change here with nl80211 and I'm not exactly
keen on change driver_*.c behavior without anyone having tested the
changes. driver_wext.c may actually be covered in hwsim testing, but the
other ones would need manual testing if code review cannot clearly show
that there is no change in actually driver operations. Each driver_*.c
can be handled separately after having been tested or reviewed.
Perfectly fine. Some of the older patch series had the set_tx removal at
the very end of the series. I'll migrate the API to the parameter struct
with set_tx and drop this patch from the next series.
Alexander
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
