Re: [PATCH] nl80211: Donot use external_auth when driver does not support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 10, 2019 at 03:19:19PM +0530, Nishant Chaprana wrote:
> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> @@ -2465,7 +2465,8 @@ static int
> nl80211_mgmt_subscribe_ap_dev_sme(struct i802_bss *bss)
>         if (nl80211_action_subscribe_ap(bss))
>                 goto out_err;
> 
> -       if (bss->drv->device_ap_sme) {
> +       if (bss->drv->device_ap_sme &&
> +           (bss->drv->capa.flags & WPA_DRIVER_FLAGS_SME)) {
>                 u16 type = (WLAN_FC_TYPE_MGMT << 2) | (WLAN_FC_STYPE_AUTH << 4);
> 
>                 /* Register for all Authentication frames */

Could you please clarify why this would be needed and why
WPA_DRIVER_FLAGS_SME is used here? That flag indicates that the driver
uses wpa_supplicant SME in station mode and as such, is not really
supposed to be used for determining how to behave in AP mode. What
exactly does this fix? Are you sure this does not break SAE in AP mode
with drivers that need to use hostapd to perform SAE authentication?

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux