On Fri, Dec 06, 2019 at 02:27:44PM -0800, Matthew Wang wrote: > Chrome OS relies on its connection manager, shill, to bump up the > logging level in wpa_supplicant during 'interesting' times via its > WiFi::SetConnectionDebugging method. The method sets wpa_supplicant > debug level to 'info' (quieter) or 'debug' (when verbose). > Currently, it is not guaranteed that SetConnectionDebugging will be > called on all roaming paths, therefore we end up with two scenarios in > the logs: one where roaming happens out of the blue, like so (timestamp > removed): > The second scenario, and the preferable one, is where we get details of > how roaming decisions were made. This happens when > WiFi::SetConnectionDebugging(true) is on the execution path, which seems > to be only when connecting to a new service: ... > Until we have confidence that all roaming scenarios do go through shill > and can be intercepted with WiFi::SetConnectionDebugging(true), the > safer route is to bump up the logging level of the following directly > in wpa_supplicant itself: > - roaming decisions. > - estimated throughput and channel quality calculations. This would result in significant increase in how much debug information in logged in default (INFO) level. I don't think this is really desired default behavior. > - wpa_dbg(wpa_s, MSG_DEBUG, "Considering within-ESS reassociation"); > - wpa_dbg(wpa_s, MSG_DEBUG, "Current BSS: " MACSTR > + wpa_dbg(wpa_s, MSG_INFO, "Considering within-ESS reassociation"); > + wpa_dbg(wpa_s, MSG_INFO, "Current BSS: " MACSTR And as far as this type of changes from MSG_INFO to MSG_DEBUG with wpa_dbg() are concerned, it should be noted that wpa_dbg() is a special version of wpa_msg(). wpa_dbg() can be removed from builds with CONFIG_NO_STDOUT_DEBUG to save space. That is unlikely desired for cases where you might want to log such debug messages in logs (other than stdout). In other words, wpa_dbg(MSG_DEBUG) would need to be replaced with wpa_msg(MSG_INFO) if the purpose is to get the particular debug entries into all logs by default. Anyway, since I'm not convinced all these roaming related debug messages should be included by default, I'm not planning on applying patches 1..3 unless there is stronger justification for this. If more detailed debugging information is needed, I'd run wpa_supplicant with -d (i.e., in DEBUG verbosity instead of the default INFO). -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
