I'm maybe (probably) looking at the wrong tree, but the changes to
wpa_driver_nl80211_send_mlme look redundant?
Version I'm looking at already has:
if ((is_sta_interface(drv->nlmode) ||
drv->nlmode == NL80211_IFTYPE_P2P_DEVICE) &&
WLAN_FC_GET_TYPE(fc) == WLAN_FC_TYPE_MGMT &&
WLAN_FC_GET_STYPE(fc) == WLAN_FC_STYPE_PROBE_RESP) {
Also, I don't know the significance but I noticed a difference
regarding wait_time and other usages of nl80211_send_frame_cmd, where
there is a tertiary operator to check for off chan
On Mon, Dec 16, 2019 at 12:00 PM <hostap-request@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Send Hostap mailing list submissions to
> hostap@xxxxxxxxxxxxxxxxxxx
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://lists.infradead.org/mailman/listinfo/hostap
> or, via email, send a message with subject or body 'help' to
> hostap-request@xxxxxxxxxxxxxxxxxxx
>
> You can reach the person managing the list at
> hostap-owner@xxxxxxxxxxxxxxxxxxx
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Hostap digest..."
>
>
> Today's Topics:
>
> 1. [PATCH 5/5] wpa_supplicant: fall back to avg_signal (Matthew Wang)
> 2. [PATCH v2 03/40] nl80211: Allow off-channel of authentication
> frames in send_mlme() (Ilan Peer)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Fri, 6 Dec 2019 14:27:48 -0800
> From: Matthew Wang <matthewmwang@xxxxxxxxxxxx>
> To: j@xxxxx
> Cc: hostap@xxxxxxxxxxxxxxxxxxx, matthewmwang@xxxxxxxxxxxx,
> briannorris@xxxxxxxxxxxx
> Subject: [PATCH 5/5] wpa_supplicant: fall back to avg_signal
> Message-ID: <20191206222748.153534-5-matthewmwang@xxxxxxxxxxxx>
>
> Some drivers (e.g. Marvell WiFi) don't report avg_beacon_signal, but
> it's still useful to poll for the signal again when a roaming decision
> needs to be made. Use si.avg_signal when si.avg_beacon_signal is not
> available.
>
> Signed-off-by: Matthew Wang <matthewmwang@xxxxxxxxxxxx>
> ---
> wpa_supplicant/events.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/wpa_supplicant/events.c b/wpa_supplicant/events.c
> index cf0aa2b57..c87011297 100644
> --- a/wpa_supplicant/events.c
> +++ b/wpa_supplicant/events.c
> @@ -1667,7 +1667,7 @@ static void wpa_supplicant_rsn_preauth_scan_results(
>
> static int wpas_get_snr_signal_info(const struct wpa_signal_info *si)
> {
> - int noise = IS_5GHZ(si->frequency) ?
> + int noise = IS_5GHZ(frequency) ?
> DEFAULT_NOISE_FLOOR_5GHZ :
> DEFAULT_NOISE_FLOOR_2GHZ;
>
> @@ -1676,7 +1676,7 @@ static int wpas_get_snr_signal_info(const struct wpa_signal_info *si)
> * the current noise measurement (average vs. snapshot),
> * so use the default values instead.
> */
> - return si->avg_beacon_signal - noise;
> + return avg_signal - noise;
> }
>
>
> @@ -1772,10 +1772,10 @@ static int wpa_supplicant_need_to_roam(struct wpa_supplicant *wpa_s,
> * get fresh information about our own AP, do that.
> */
> if (!wpa_drv_signal_poll(wpa_s, &si)) {
> - if (si.avg_beacon_signal) {
> - int snr = wpas_get_snr_signal_info(&si);
> + if (si.avg_beacon_signal || si.avg_signal) {
> + cur_level = si.avg_beacon_signal ? si.avg_beacon_signal : si.avg_signal;
> + int snr = wpas_get_snr_signal_info(si.frequency, cur_level);
>
> - cur_level = si.avg_beacon_signal;
> cur_est = wpas_get_est_throughput_from_bss_snr(wpa_s,
> current_bss,
> snr);
> --
> 2.24.0.393.g34dc348eaf-goog
>
>
>
>
> ------------------------------
>
> Message: 2
> Date: Mon, 16 Dec 2019 16:59:13 +0200
> From: Ilan Peer <ilan.peer@xxxxxxxxx>
> To: hostap@xxxxxxxxxxxxxxxxxxx
> Cc: Ilan Peer <ilan.peer@xxxxxxxxx>
> Subject: [PATCH v2 03/40] nl80211: Allow off-channel of authentication
> frames in send_mlme()
> Message-ID: <20191216145913.23794-1-ilan.peer@xxxxxxxxx>
>
> As part of the support needed for PASN.
>
> Signed-off-by: Ilan Peer <ilan.peer@xxxxxxxxx>
> ---
> src/drivers/driver_nl80211.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/drivers/driver_nl80211.c b/src/drivers/driver_nl80211.c
> index efc2eb7176..2f5cd5fa7b 100644
> --- a/src/drivers/driver_nl80211.c
> +++ b/src/drivers/driver_nl80211.c
> @@ -3723,6 +3723,14 @@ static int wpa_driver_nl80211_send_mlme(struct i802_bss *bss, const u8 *data,
> MAC2STR(mgmt->da), noack, freq, no_cck, offchanok, wait_time,
> fc, fc2str(fc), drv->nlmode);
>
> + if (is_sta_interface(drv->nlmode) &&
> + WLAN_FC_GET_TYPE(fc) == WLAN_FC_TYPE_MGMT &&
> + WLAN_FC_GET_STYPE(fc) == WLAN_FC_STYPE_AUTH) {
> + return nl80211_send_frame_cmd(bss, freq, wait_time,
> + data, data_len, NULL, 1, noack,
> + 1, csa_offs, csa_offs_len);
> + }
> +
> if ((is_sta_interface(drv->nlmode) ||
> drv->nlmode == NL80211_IFTYPE_P2P_DEVICE) &&
> WLAN_FC_GET_TYPE(fc) == WLAN_FC_TYPE_MGMT &&
> --
> 2.17.1
>
>
>
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> Hostap mailing list
> Hostap@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/hostap
>
>
> ------------------------------
>
> End of Hostap Digest, Vol 51, Issue 22
> **************************************
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
