2016-08-22, 21:12:42 +0300, Jouni Malinen wrote: > On Mon, Aug 15, 2016 at 11:43:43AM +0200, Sabrina Dubroca wrote: > > Signed-off-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx> > > Could you please provide a bit more detailed commit message describing > why this would be done? I reuse these structures in the next patch, which makes the driver ops for MACsec cleaner, IMHO. I will add this information to the commit message if I update and resend this patch. > > src/common/ieee802_1x_defs.h | 69 +++++++++++++++++++++++++++++++++++++++++++ > > I'm not sure src/common/*.h is an appropriate location for this type of > definitions. I'd expect this file to include frame definitions and that > type of common defines/structures while the structs added here look more > like implementation specific data. I see. Well, these structs are more or less defined by the standard, in that the standard describes the settings relevant for these items, but I guess it could go either way. I don't mind leaving them in src/pae, it's your call. > What would those be shared with (outside src/pae) and what is the > "common" part here? With drivers that support MACsec. From your reply to patch 6, I suppose that they at least need to be moved out of ieee802_1x_kay_i.h if we want to use them in drivers. Thanks for the feedback, -- Sabrina _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
