Re: [PATCH 5/6] mka: move structs {transmit, receive}_{sa, sc} to a common header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 15, 2016 at 11:43:43AM +0200, Sabrina Dubroca wrote:
> Signed-off-by: Sabrina Dubroca <sd@xxxxxxxxxxxxxxx>

Could you please provide a bit more detailed commit message describing
why this would be done?

>  src/common/ieee802_1x_defs.h  | 69 +++++++++++++++++++++++++++++++++++++++++++

I'm not sure src/common/*.h is an appropriate location for this type of
definitions. I'd expect this file to include frame definitions and that
type of common defines/structures while the structs added here look more
like implementation specific data. What would those be shared with
(outside src/pae) and what is the "common" part here?

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux