Re: [PATCH 6/6] mka: pass full structures down the stack in ops callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 15, 2016 at 11:43:44AM +0200, Sabrina Dubroca wrote:
> Instead of extracting some specific arguments, pass the structures down
> to the driver and let it use what it needs.

> diff --git a/src/drivers/driver_macsec_qca.c b/src/drivers/driver_macsec_qca.c
> @@ -31,6 +31,9 @@
> +#include "pae/ieee802_1x_kay.h"
> +#include "pae/ieee802_1x_kay_i.h"

The "_i.h" end in a header file name in wpa_supplicant is a convention
that is used to identify a header file with internal definitions. Such
header files are not supposed to be included into files in other
directories.  In other words, if there is something that driver wrappers
would need from ieee802_1x_kay_i.h, that something would need to be
moved into ieee802_1x_kay.h or maybe even src/drivers/driver.h if this
is part of a driver wrapper API.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux