On Thu, Oct 22, 2015 at 02:12:09PM +0000, Peer, Ilan wrote: > > > Redirect the commands ADD_NETWORK and SET_NETWORK from the global > > > control interface to the P2P Device interface to enable adding netwrok > > > profiles to the P2P Device interface. > These were under CONFIG_TESTING_OPTIONS since we were not aware of any real use case for this other than hwsim testing. They can be supported on global control interface without limitation AFAIC. In general, it may be fine to add CONFIG_TESTING_OPTIONS blocks in the implementation, but that is certainly not the preference and should be left for cases where testing cannot be done without the change. In this specific case, I don't see why this would need to be handled through wpas_global_ctrl_iface_redir_p2p(), i.e., the test script should be capable of directing the command to the appropriate interface directly. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
