Re: [PATCH 05/14] tests: Change persistent_group_missed_inv_resp() test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 22, 2015 at 02:09:44PM +0000, Peer, Ilan wrote:
> > > Support configurations that use a dedicated P2P device interface by
> > > setting ext_mgmt_frame_handling and waiting for MGMT-RX event on the
> > > global control interface.

> Would you prefer to handle this by adding an argument to the mgmt._rx to state if this is P2P frame or not and have the method resolve the interface name internally based on whether P2P Device is used or not (something similar to list_networks()).

To be honest, I'm not sure I'd want either and I'm not sure I understand
the need to make this specific test case "work" with the where
mac80211_hwsim is forced to use a separate P2P Device interface. I would
much rather focus on making sure there is sufficient coverage for both
options in test cases without relying to running tests with custom
configuration that results in this type of issues in the first place. In
other words, I'd rather leave this as-is and if something is missing
from testing coverage with P2P Device interface, that should addressed
by adding a new test case that adds a dynamic hwsim radio with P2P
Device interface and then appropriately targeted SET and wait-event
commands on the interface that handles P2P messages.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux