RE: GnuGK bug report

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	Sure :)

   In current state gnugk will try to bind to "Home=" IP address without checking if it is set or not, so it still needs couple of touches before it can be included into distribution. 

============ ProxyChannel.cxx ====================
141a142
>       bool Bind2IP(const PIPSocket::Address ip, WORD pt);
311c312,313
<       localAddr = RasThread->GetLocalAddress(peerAddr);
---
> //    localAddr = RasThread->GetLocalAddress(peerAddr);
>       localAddr = RasThread->GetGKHome();
1747a1750,1769
> bool UDPProxySocket::Bind2IP(const PIPSocket::Address ip, WORD pt)
> {
>       if (!Listen(ip, 0, pt))
>               return false;
> 
>       // Set the IP Type Of Service field for prioritisation of media UDP packets
> #ifdef WIN32
>       // Windows MultMedia stuff seems to need greater depth due to enormous
>       // latencies in its operation, need to use DirectSound maybe?
>       int rtpIpTypeofService = IPTOS_PREC_CRITIC_ECP | IPTOS_LOWDELAY;
> #else
>       // Don't use IPTOS_PREC_CRITIC_ECP on Unix platforms as then need to be root
>       int rtpIpTypeofService = IPTOS_LOWDELAY;
> #endif
>       if (!ConvertOSError(::setsockopt(os_handle, IPPROTO_IP, IP_TOS, (char *)&rtpIpTypeofService, sizeof(int)))) {
>               PTRACE(1, Type() << "\tCould not set TOS field in IP header: " << GetErrorText(PSocket::LastGeneralError));
>       }
>       return true;
> }
> 
1837c1859,1860
<               if (rtp->Bind(port) && rtcp->Bind(port + 1))
---
> //            if (rtp->Bind(port) && rtcp->Bind(port + 1))
>               if (rtp->Bind2IP(RasThread->GetGKHome(), port) && rtcp->Bind2IP(RasThread->GetGKHome(), port + 1))
=====================================================


-----Original Message-----
From: Zygmuntowicz Michal [mailto:m.zygmuntowicz@onet.pl]
Sent: Wednesday, October 08, 2003 2:12 AM
To: openh323gk-users@lists.sourceforge.net
Subject: Re:  GnuGK bug report


Hi Julius,

could I take a look at the patch?:)

----- Original Message ----- 
From: "Julius Stavaris" <TJST@bite.lt>
Sent: Tuesday, October 07, 2003 3:21 PM


  Well not sure if it is a bug but when you run gnugk in proxy mode not all packets get originated from ip address
defined in "Home=" setting ( UDPProxySocket::Bind and inside of CallSignalSocket::SetRemote in ProxyChannel.cxx). With
some help I was able to patch gnugk to force gnugk to originate all packets from "home" address. After that gatekeepers
could pass calls to each other.
  Being network engineer and very poor programmer I never made an "elegant" patch (patched gnugk always requires "Home"
to be set), so I never committed patch to public, but if you're interested I can send updated ProxyChannel.cxx to you or
to the public list if anyone is willing to polish the patch to be included into release version.



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
List: Openh323gk-users@lists.sourceforge.net
Archive: http://sourceforge.net/mailarchive/forum.php?forum_id=8549
Homepage: http://www.gnugk.org/


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
List: Openh323gk-users@lists.sourceforge.net
Archive: http://sourceforge.net/mailarchive/forum.php?forum_id…49
Homepage: http://www.gnugk.org/


[Index of Archives]     [SIP]     [Open H.323]     [Gnu Gatekeeper]     [Asterisk PBX]     [ISDN Cause Codes]     [Yosemite News]

  Powered by Linux