On 12/08/2010 05:17 PM, Dr Andrew John Hughes wrote: > On 11:13 Wed 08 Dec , Andrew Haley wrote: >> On 12/08/2010 10:58 AM, Pekka Enberg wrote: >>> On Wed, Dec 8, 2010 at 12:32 PM, Andrew Haley <aph@xxxxxxxxxx> wrote: >>>> I hereby offer to review some patches. Please send pointers to the >>>> list. >>> >>> http://developer.classpath.org/pipermail/classpath-patches/2010-November/006511.html >> >> This needs a ChangeLog, otherwise OK. >> >>> http://developer.classpath.org/pipermail/classpath-patches/2010-November/006513.html >> >> This needs a ChangeLog, otherwise OK. >> > > I've already seen these and I agree both seem fine. But Pekka needs a copyright > assignment before any more work can be committed. > >>> http://developer.classpath.org/pipermail/classpath-patches/2010-November/006512.html >> >> What compatibility problem does this fix? >> > > I'd like to see a test case in Mauve for this before we change this. That's not a good reason not to commit: the fix is in other versions, including gcj. Andrew.
