On Friday, May 24, 2013 14:31:33 Andrew Bartlett wrote: > On Thu, 2013-05-23 at 22:30 -0400, Anand Avati wrote: > > static char *vfs_gluster_getwd(struct vfs_handle_struct *handle) > > +{ > > + char *cwd; > > + char *ret; > > + > > + cwd = TALLOC_ZERO(NULL, PATH_MAX+1); > > + if (!cwd) > > + return NULL; > > + > > + ret = glfs_getcwd(handle->data, cwd, PATH_MAX); > > + if (!ret) > > + TALLOC_FREE(cwd); > > + return ret; > > +} It is not a blocker for the patch but it would be nice if you could apply our coding styles in future. See https://blog.cryptomilk.org/2013/03/28/writing-and-reading-code/ Thanks, -- andreas