Re: [PATCH 3/3 v4] vfs_glusterfs: Samba VFS module for glusterfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/24/13 1:03 AM, Andreas Schneider wrote:
On Friday, May 24, 2013 14:31:33 Andrew Bartlett wrote:
On Thu, 2013-05-23 at 22:30 -0400, Anand Avati wrote:
static char *vfs_gluster_getwd(struct vfs_handle_struct *handle)
+{
+       char *cwd;
+       char *ret;
+
+       cwd = TALLOC_ZERO(NULL, PATH_MAX+1);
+       if (!cwd)
+               return NULL;
+
+       ret = glfs_getcwd(handle->data, cwd, PATH_MAX);
+       if (!ret)
+               TALLOC_FREE(cwd);
+       return ret;
+}

It is not a blocker for the patch but it would be nice if you could apply our
coding styles in future. See

https://blog.cryptomilk.org/2013/03/28/writing-and-reading-code/



Thanks for the pointer, I have cleaned it up to the extent I could find. Next patch version will have the changes.

Avati





[Index of Archives]     [Gluster Users]     [Ceph Users]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux