Re: [PATCH][v2] http authentication via prompts (with correct line lengths)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 9 Mar 2009, Mike Gaffney wrote:

> I guess it makes sense to split the config out into two patches.

I guess, too, because it has been asked for.  I guess that since nobody 
contradicted that wish, it would make sense, I guess.

> I wanted both to help with automated builds, and as it's a read only 
> account I wasn't worried about someone reading the password. I'm not 
> very impressed with the permissions on the .netrc file actually 
> providing security so I can see not allowing the password in the config 
> either.

If Git were written for you, for that very specific setup, then yes, I can 
see that one does not need to care about storing passwords in plaintext 
files _there_.

However, in addition to you, Git was written for some others, too.

And $HOME/.netrc is a well established paradigm, many programs check the 
permissions and flatly refuse to run with a big red warning if the 
permissions are not set restrictively.  So there is definitely a big, 
huge, vast difference between storing passwords in $HOME/.netrc and 
storing them in .git/config.

> In my system at work, we have shared machines but all developers have 
> root access, so file permissions don't really secure anything for us. 
> It's also why we can't really use keys (there is no way to enforce that 
> a key is secured afaik).

Again, happily the Git team decided that in addition to you, we want to 
support other users.  For example us.

And we _do_ work on computers where only trustworthy people have root 
access.

> I wanted to do a remote specific config as well but a global works well 
> in many environments where your push repo is under http as you don't 
> keep having to configure it.

IMHO in this case, "works well" does not mean the same as "makes sense" at 
all.

Again, Git was written for other people, too.

It should not be necessary to say more, but here I go: on two projects I 
have to push to multiple HTTP servers, and I do have different passwords 
there.

However, I am pretty convinced that it is a good idea to have the 
passwords in $HOME/.netrc where they belong instead of in a config where 
it is all too easy to fsck up the permissions.

BTW that is another reason (in addition to it just being good style, 
separating different issues into different patches) why I want you to 
split the patch: to reject something insecure (storing passwords in 
config) and to accept the secure part (reading passwords interactively 
from the console).

> I also couldn't see a good way to do a remote specific config without 
> changing the remote struct (which seemd like putting specific in a 
> general). I would love some advice on this and where to put it.

Umm.  Into the remote struct?

> I can see your security points but I would argue that if that's what we 
> are worried about then we should not allow the netrc file at all.

See above.

> I added notes in the config documentation about this. I'm open to 
> discussion on this point.

Oh, so you mean you will address my concerns?  That's good, as I am 
looking forward to your answers to them.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux