Hi, On Tue, 10 Mar 2009, Johannes Sixt wrote: > From: Johannes Sixt <j6t@xxxxxxxx> > > This removes the last parameter of recv_sideband, by which the callers > told which channel band #2 data should be written to. Since both callers > of the function passed 2 for the parameter, we hereby remove the > parameter and send band #2 to stderr explicitly using fprintf. To be honest, I considered this myself. But I think it is wrong. Just because the current callers happen to output to stderr does not mean that we would not like sidebands that exchange binary data for other uses in the future. I am thinking GitTorrent here. And clearly, sideband support was written with future uses like that in mind, as it goes out of its way to transmit packets instead of strings. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
