Junio C Hamano wrote:
> Jay Soffian <jaysoffian@xxxxxxxxx> writes:
>
>> On Thu, Feb 26, 2009 at 5:37 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> I don't mind Perl as we already depend on it; the looseness of the regexp
>>> stil bothers me somewhat, though...
>> I think you're letting the perfect be the enemy of the good. The point
>> of the test is merely to check for the SHA-1 has suffix in PUT/MOVE
>> operations. Any of my suggestions so far are better than what is there
>> now. Why so much fuss?
>>
>> I'll send one more iteration, and if that's not good enough, I give up.
>>
>> j.
>
> Heh, at least with /a-z/a-f/, I think it is usable.
Two minor style issues can also be fixed.
I think the file name can be specified as an argument to sed rather than using
the shell's redirection mechanism.
sed -e 'script' input-file
rather than
sed -e 'script' < input-file
I think /that/, and moving the pipe character to the end of the sed line so that
you don't need to escape the newline will conform to git scripting style so it
becomes:
sed -e "s/PUT/OP/" -e "s/MOVE/OP/" "$HTTPD_ROOT_PATH"/access.log |
grep "\"OP .*/objects/$x2/${x38}_$x40 HTTP/[.0-9]*\" 20[0-9]"
-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
