>> +x1="[a-z0-9]"
>
> Why [a-z0-9] not [0-9a-f]?
No reason. It's just what popped out of my head.
> I'd rather see the basic BRE grep used if you are shooting for
> portability.
>
> There are some oddballs in the source (git-submodule.sh is a notable
> offender) but none of the core-ish scripts uses egrep nor "grep -E".
Sigh, I just wanted the test to pass. I did a check to see if any
other tests were already using egrep, and when I found that they were,
I thought that would be good enough.
Originally I had switched to perl. Would you prefer:
diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
index 11b3432..a53fe0d 100755
--- a/t/t5540-http-push.sh
+++ b/t/t5540-http-push.sh
@@ -96,8 +96,8 @@ test_expect_success 'MKCOL sends directory names
with trailing slashes' '
test_expect_success 'PUT and MOVE sends object to URLs with SHA-1
hash suffix' '
- grep -P "\"(?:PUT|MOVE)
.+objects/[\da-z]{2}/[\da-z]{38}_[\da-z\-]{40} HTTP/[0-9.]+\" 20\d" \
- < "$HTTPD_ROOT_PATH"/access.log
+ test $(perl -ne "print if m{\"(?:PUT|MOVE)
.+objects/[\da-z]{2}/[\da-z]{38}_[\da-z\-]{40} HTTP/[0-9.]+\" 20\d}" \
+ < "$HTTPD_ROOT_PATH"/access.log | wc -l) -gt 0
'
?
j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
