Re: [PATCH] t5540-http-push.sh: avoid non-portable grep -P

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 26, 2009 at 3:43 PM, Jay Soffian <jaysoffian@xxxxxxxxx> wrote:
> Originally I had switched to perl. Would you prefer:
>
> diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
> index 11b3432..a53fe0d 100755
> --- a/t/t5540-http-push.sh
> +++ b/t/t5540-http-push.sh
> @@ -96,8 +96,8 @@ test_expect_success 'MKCOL sends directory names
> with trailing slashes' '
>
>  test_expect_success 'PUT and MOVE sends object to URLs with SHA-1
> hash suffix' '
>
> -       grep -P "\"(?:PUT|MOVE)
> .+objects/[\da-z]{2}/[\da-z]{38}_[\da-z\-]{40} HTTP/[0-9.]+\" 20\d" \
> -               < "$HTTPD_ROOT_PATH"/access.log
> +       test $(perl -ne "print if m{\"(?:PUT|MOVE)
> .+objects/[\da-z]{2}/[\da-z]{38}_[\da-z\-]{40} HTTP/[0-9.]+\" 20\d}" \
> +               < "$HTTPD_ROOT_PATH"/access.log | wc -l) -gt 0
>
>  '

gmail mangled the lines. Sorry about that.

BTW, I was not aiming for "portable" to the extent that git is
portable, I was aiming for "portable enough" to the extent that the
test suite is portable. :-)

Let me know if the perl above is okay, or if you'd prefer a basic RE
and I'll send a new patch.

j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux