Jay Soffian <jaysoffian@xxxxxxxxx> writes:
> OS X's GNU grep does not support -P/--perl-regexp; use egrep instead,
> avoiding non-portable braces ({}) as well.
>
> Signed-off-by: Jay Soffian <jaysoffian@xxxxxxxxx>
> ---
> t/t5540-http-push.sh | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/t/t5540-http-push.sh b/t/t5540-http-push.sh
> index 11b3432..6a255a6 100755
> --- a/t/t5540-http-push.sh
> +++ b/t/t5540-http-push.sh
> @@ -94,9 +94,15 @@ test_expect_success 'MKCOL sends directory names with trailing slashes' '
>
> '
>
> +x1="[a-z0-9]"
Why [a-z0-9] not [0-9a-f]?
> +x2="$x1$x1"
> +x5="$x1$x1$x1$x1$x1"
> +x38="$x5$x5$x5$x5$x5$x5$x5$x1$x1$x1"
> +x40="$x38$x2"
> +
> test_expect_success 'PUT and MOVE sends object to URLs with SHA-1 hash suffix' '
>
> - grep -P "\"(?:PUT|MOVE) .+objects/[\da-z]{2}/[\da-z]{38}_[\da-z\-]{40} HTTP/[0-9.]+\" 20\d" \
> + egrep "\"(PUT|MOVE) .+objects/$x2/${x38}_$x40 HTTP/[0-9.]+\" 20[0-9]" \
> < "$HTTPD_ROOT_PATH"/access.log
I'd rather see the basic BRE grep used if you are shooting for
portability.
There are some oddballs in the source (git-submodule.sh is a notable
offender) but none of the core-ish scripts uses egrep nor "grep -E".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
