Re: [PATCH] filter-branch -d: Export GIT_DIR earlier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Johannes Schindelin <Johannes.Schindelin@xxxxxx> [09-02-16 18:52]:
Hi,

On Mon, 16 Feb 2009, Lars Noschinski wrote:

* Johannes Schindelin <Johannes.Schindelin@xxxxxx> [09-02-16 15:42]:
> > This fix is not yet ready for commit, as it lacks a test case.
> > > > Writing a test case for this bug, I wonder about the preferred way to use
> > a
> > directory outside any git repository in a test: Using some directory below
> > git/t/ will not work, as (in most cases) git is a git repository.
[...]
Next try: is it not true that we can check that "$tempdir/backup-refs" is correct, i.e. identical to what 'for-each-ref' outputs for the desired directory?

True.

So we could make a subdirectory, set up a dummy branch with one commit, call filter-branch with a tmpdir that is in _another_ subdirectory, with a filter that just returns false, so that the tmpdir is not deleted, and verify the contents of $tmpdir/backup-refs, no?

AFAICS $tmpdir is always deleted, filter-branch sets a trap to ensure
this. But using a filter to copy backup-refs elsewhere works. Patch
follows.

 - Lars.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux