Hi, On Mon, 16 Feb 2009, Lars Noschinski wrote: > The improved error handling catches a bug in filter-branch when using > -d pointing to a path outside any git repository: > > $ mkdir foo > $ cd foo > $ git init > $ touch bar > $ git add bar > $ git commit -m bar > $ cd .. > $ git clone --bare foo > $ cd foo.git > $ git filter-branch -d /tmp/filter master > fatal: Not a git repository (or any of the parent directories): .git > > This error message comes from git for-each-ref in line 224. GIT_DIR is > set correctly by git-sh-setup (to the foo.git repository), but not > exported (yet). Thanks. > --- > > This fix is not yet ready for commit, as it lacks a test case. > > Writing a test case for this bug, I wonder about the preferred way to use a > directory outside any git repository in a test: Using some directory below > git/t/ will not work, as (in most cases) git is a git repository. How about using a filter-branch call with a filter that echoes GIT_DIR into a file, then fails, and then checking the exact contents of GIT_DIR? Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
