Re: [PATCH] filter-branch -d: Export GIT_DIR earlier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

* Johannes Schindelin <Johannes.Schindelin@xxxxxx> [09-02-16 15:42]:
This fix is not yet ready for commit, as it lacks a test case.

Writing a test case for this bug, I wonder about the preferred way to use a
directory outside any git repository in a test: Using some directory below
git/t/ will not work, as (in most cases) git is a git repository.

How about using a filter-branch call with a filter that echoes GIT_DIR into a file, then fails, and then checking the exact contents of GIT_DIR?

This would not catch this bug: for-each-ref is the only git command
called after changing to the temporary directory and before exporting
GIT_DIR.

It would help only if GIT_DIR would never be exported.

- Lars.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux