On Sat, Jan 03, 2009 at 11:53:56PM -0800, Junio C Hamano wrote: > Christian Couder <chriscool@xxxxxxxxxxxxx> writes: > > > Le jeudi 1 janvier 2009, Ramsay Jones a écrit : > > ... > >> Does anybody else see this issue and can someone test the patch? > > > > Petr, as you added support for using /bin/start on MinGW, could you test? Sorry, I don't have access to MinGW system anymore. > > diff --git a/git-web--browse.sh b/git-web--browse.sh > > index 78d236b..7ed0fad 100755 > > --- a/git-web--browse.sh > > +++ b/git-web--browse.sh > > @@ -115,7 +115,7 @@ if test -z "$browser" ; then > > browser_candidates="open $browser_candidates" > > fi > > # /bin/start indicates MinGW > > - if test -n /bin/start; then > > + if test -x /bin/start; then > > browser_candidates="start $browser_candidates" > > fi > > In any case, the original test is simply bogus. 'test -n "$foo"' is to > see if $foo is an empty string, and giving a constant /bin/start always > yields true. Oops. :-) That should've obviously been -f. -- Petr "Pasky" Baudis The average, healthy, well-adjusted adult gets up at seven-thirty in the morning feeling just terrible. -- Jean Kerr -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
