Christian Couder <chriscool@xxxxxxxxxxxxx> writes: > Le jeudi 1 janvier 2009, Ramsay Jones a écrit : > ... >> Does anybody else see this issue and can someone test the patch? > > Petr, as you added support for using /bin/start on MinGW, could you test? > > Thanks, > Christian. > diff --git a/git-web--browse.sh b/git-web--browse.sh > index 78d236b..7ed0fad 100755 > --- a/git-web--browse.sh > +++ b/git-web--browse.sh > @@ -115,7 +115,7 @@ if test -z "$browser" ; then > browser_candidates="open $browser_candidates" > fi > # /bin/start indicates MinGW > - if test -n /bin/start; then > + if test -x /bin/start; then > browser_candidates="start $browser_candidates" > fi In any case, the original test is simply bogus. 'test -n "$foo"' is to see if $foo is an empty string, and giving a constant /bin/start always yields true. As an old timer, I tend to prefer "test -f" in this context, as anybody sane can expect that the directory /bin will contain executables and nothing else. Another reason is purely stylistic. Historically "-f" has been much more portable than "-x" (which came from SVID), even though it wouldn't make much difference in practice in the real world these days. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
