On Tue, 11 Nov 2008, H.Merijn Brand wrote:
On Tue, 11 Nov 2008 09:47:00 -0800, Junio C Hamano <gitster@xxxxxxxxx>
wrote:
Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes:
On Mon, Nov 10, 2008 at 05:31:01PM +0100, "H.Merijn Brand" <h.m.brand@xxxxxxxxx> wrote:
--- Makefile.org 2008-11-10 17:29:53.000000000 +0100
+++ Makefile 2008-11-10 17:29:39.000000000 +0100
@@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X
./test-sha1.sh
check: common-cmds.h
+ @`sparse </dev/null 2>/dev/null` || (\
+ echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\
+ echo "Did you mean 'make test' instead?" ;\
+ exit 1 )
for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
Please read Documentation/SubmittingPatches, your patch lacks a signoff
and a commit message.
Here is a check list I use to make sure my patches are OK.
http://repo.or.cz/w/git.git?a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD
...
I'm by now way offended or scared away if you reject these kind of
patches
The crowed here may seem harsh but they really are not. They just have a
lot to do and getting things to them in a format that is easy to follow
and uses the above URL guildlines assists them in looking at the patches,
commit messages and sign-off. Git requires a sign-off in order for them
to use the patches. It is a way to make sure everything is kept above
board and proper. This allow ever line of code to have a resource as to
where and whence it ...
Do not give up. Just try to do things in a manner that is easy to allow
your patches into Git.
Good Luck,
--
Boyd Gerber <gerberb@xxxxxxxxx>
ZENEZ 1042 East Fort Union #135, Midvale Utah 84047
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
