On Mon, 10 Nov 2008 12:39:24 +0100, Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> wrote: > On Mon, Nov 10, 2008 at 12:17:39PM +0100, "H.Merijn Brand" <h.m.brand@xxxxxxxxx> wrote: > > git-1.6.0.4 112 > make check > > for i in *.c; do sparse -g -O2 -Wall -DSHA1_HEADER='<openssl/sha.h>' -DNO_STRLCPY -D__BIG_ENDIAN__ -D__powerpc__ $i || exit; done > > /bin/sh: sparse: command not found > > make: *** [check] Error 127 > > > > Maybe the Makefile could be a little more user-friendly with a message > > like > > > > "Cannot run 'make check', as you do not have 'sparse' installed. > > Did you mean to run 'make test' instead?" > > Care to send a patch? --- Makefile.org 2008-11-10 17:29:53.000000000 +0100 +++ Makefile 2008-11-10 17:29:39.000000000 +0100 @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X ./test-sha1.sh check: common-cmds.h + @`sparse </dev/null 2>/dev/null` || (\ + echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\ + echo "Did you mean 'make test' instead?" ;\ + exit 1 ) for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done remove-dashes: -- H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
