On Tue, 11 Nov 2008 09:47:00 -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes: > > > On Mon, Nov 10, 2008 at 05:31:01PM +0100, "H.Merijn Brand" <h.m.brand@xxxxxxxxx> wrote: > >> --- Makefile.org 2008-11-10 17:29:53.000000000 +0100 > >> +++ Makefile 2008-11-10 17:29:39.000000000 +0100 > >> @@ -1329,6 +1329,10 @@ check-sha1:: test-sha1$X > >> ./test-sha1.sh > >> > >> check: common-cmds.h > >> + @`sparse </dev/null 2>/dev/null` || (\ > >> + echo "The 'sparse' command is not available, so I cannot make the 'check' target" ;\ > >> + echo "Did you mean 'make test' instead?" ;\ > >> + exit 1 ) > >> for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done > > > > Please read Documentation/SubmittingPatches, your patch lacks a signoff > > and a commit message. > > Heh, for something small and obvious like this, that's asking a tad too > much, although a properly formatted message does reduce my workload and is > appreciated. Junio++ > I said "obvious" not in the sense that it is "obviously good". It is > obvious what issue the patch wants to address. > > Having said that, it is far from clear if special casing "make check" like > this is a good thing, though. The crufts resulting from "Four extra lines > won't hurt" kind of reasoning can accumulate and snowball. Is reading the > Makefile when your build fails in order to see if the target was what you > really wanted to invoke (ideally, it should rater be "_before_ running > make, reading the Makefile to find out what you want to run") a lost art > these days? Not at all, and for me it was clear from the start, so I typed 'make test' and went ahead. It was that I am just all to aware of the GNU world that I can easily imagine other people making the same mistake, and just thought it end-user-friendly to do as I proposed. I'm by now way offended or scared away if you reject these kind of patches -- H.Merijn Brand Amsterdam Perl Mongers http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, SuSE 10.1, 10.2, and 10.3, AIX 5.2, and Cygwin. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
