On Fri, Oct 24, 2008 at 06:50:01PM -0400, Jeff King wrote: > However, I'm not sure exactly _where_ we would want to do this. > The obvious places are for patch, for diffstat, or for whitespace > checking. But all of those places use mmfile, so we can munge them > in the same way. I haven't looked at using this with blame, but I do > think "git blame --textconv foo.jpg" would be useful. > > (Actually not true. I did just look for 30 seconds at using this > with blame, but blame doesn't seem to to use builtin_diff at all). Ah, I see. It looks like we would have to munge fill_blob_sha1 in builtin-blame.c. In which case totally splitting this out from diff_filespec is even better, since we don't have one there. So let me try to re-roll my series based on your suggestion, and then I'll see if I can add "blame --textconv" on top. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
