On Fri, Oct 24, 2008 at 06:56:05PM -0400, Jeff King wrote: > Ah, I see. It looks like we would have to munge fill_blob_sha1 in > builtin-blame.c. In which case totally splitting this out from > diff_filespec is even better, since we don't have one there. > > So let me try to re-roll my series based on your suggestion, and then > I'll see if I can add "blame --textconv" on top. Actually, the blame thing is a little trickier than that. The textconv stuff is still tied to a diff_filespec because it uses the diff prepare_temp_file interface. So I will have to work around that if I want to add blame support. However, I re-did the existing patches according to your suggestions, and I think the result is pretty reasonable. Six patches to follow. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
