On Wed, Sep 24, 2008 at 01:25:06PM +0200, Alex Riesen wrote: > 2008/9/23 Dmitry Potapov <dpotapov@xxxxxxxxx>: > > > > I thought that in rather unusual circumstances (such as using Cygwin > > mount to connect separately directories in one tree), this fast version > > may not work. So, I made it conditional. It is runtime conditional, > > because most users do not build Git themselves but install a ready > > Cygwin package. > > So? How about make the fast version _always_ work? We don't seem > to fallback to copy+unlink everytime the POSIX rename fails. I am not sure that I understand your analogue here. First, rename has never meant to work as copy+unlink. Second, I don't fall back on some other code when the implementation provided by Cygwin fails. I replace the Cygwin implementation with a faster but a bit hackish version. Yes, it works fine in almost all practical cases I aware of, but I cannot guarantee identical behavior in _all_ cases. Frankly, I don't have strong preference here neither for making this fast version always work nor leave it conditional (perhaps, with the default setting use-fast-version). So, whatever the majority decides is fine with me. > Besides it will remove your setup code, which looks bigger and provoked > more discussion than the real subject itself. I believe Shawn wanted it to be configurable on per-repository basis. I have just finished re-writing the code in the way he suggested, so I hope all objections with the setup code are resolved now. I will send the new version a bit later, I did not have time to test it yet. Dmitry -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
