2008/9/23 Dmitry Potapov <dpotapov@xxxxxxxxx>: > On Tue, Sep 23, 2008 at 04:37:14PM +0200, Alex Riesen wrote: >> 2008/9/23 Dmitry Potapov <dpotapov@xxxxxxxxx>: >> > >> > This fast mode works only for relative paths. It is assumed that the >> > whole repository is located inside one directory without using Cygwin >> > mount to bind external paths inside of the current tree. >> >> Why runtime conditional? Why conditional at all? > > I thought that in rather unusual circumstances (such as using Cygwin > mount to connect separately directories in one tree), this fast version > may not work. So, I made it conditional. It is runtime conditional, > because most users do not build Git themselves but install a ready > Cygwin package. So? How about make the fast version _always_ work? We don't seem to fallback to copy+unlink everytime the POSIX rename fails. Besides it will remove your setup code, which looks bigger and provoked more discussion than the real subject itself. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
