Re: git-* in test scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 28, 2008 at 05:04:46PM -0700, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > On Thu, Aug 28, 2008 at 04:24:50PM -0700, Junio C Hamano wrote:
> >
> >> Test scripts are executed in a special environment whose GIT_EXEC_PATH
> >> points at the top of the build tree, where all git-foo lives.
> >
> > I am not sure how GIT_EXEC_PATH is relevant. We put the git top-level
> > directory in the PATH, which is why "git-foo" works at all in the test
> > scripts. But the install by default does _not_ put those commands in
> > the PATH. So the test scripts serve as a poor example of how to use
> > git. The commands contained within them would not run in an ordinary git
> > installation.
> 
> Well, I was merely replying to your message.  If you admit that tests are
> special and a poor example, why did you bring it up? ;-)

I don't quite follow you. I think that the tests are actively being used
by people to see how they should invoke git, but they are very bad for
that, because they are still using the dashed form. So either the people
should stop doing that, or the tests should stop using the dashed form.
I think the latter is much easier for us to control.

I sent a patch for this probably a year ago, but nobody seemed
interested. I'm sure it is hopelessly out of date at this point (it was
not as easy as a mechanical change because there are other things that
look like git-*, like filename arguments to commands).

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux