Hi, On Fri, 25 Jul 2008, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > On Fri, 18 Jul 2008, Stephan Beyer wrote: > > > >> diff --git a/editor.c b/editor.c > >> index 483b62d..5d7f5f9 100644 > >> --- a/editor.c > >> +++ b/editor.c > >> @@ -17,9 +17,8 @@ void launch_editor(const char *path, struct strbuf *buffer, const char *const *e > > ... > > Why not "return error()"? > > > > Rest looks obviously correct to me! > > This is a patch to an existing file editor.c??? Yes, Stephan sent the two patches unrelatedly, even if they should have been marked "1/2" and "2/2". I hope he does so now. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html