Hi, On Thu, 24 Jul 2008, Junio C Hamano wrote: > The function does not seem to use type (which the patch is also setting) > nor real_type (which the patch does not set). > > However, the code checks objects[nth].real_type all over the place in > the code. Doesn't the lack of real_type assignment in > append_obj_to_pack() affect them in any way? >From staring at the code, I thought that real_type was set in resolve_delta(), but I may be wrong. The safer thing would be to set it, but I am not quite sure if we can use "type" directly, or if type can be "delta" for an object that is used to complete the pack, and therefore stored as a non-delta. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
