Hi, On Fri, 18 Jul 2008, Stephan Beyer wrote: > launch_editor() is declared in strbuf.h but defined in builtin-tag.c. > This patch moves launch_editor() into a new source file editor.c, but > keeps the declaration in strbuf.h. Sorry, but that has been tried before. Junio pointed out that launch_editor() iss too die()-happy, and that the messages are too bound to the current callers. You need to at least provide an add-on patch to fix both issues. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html