Re: [PATCH 1/6] revisions: refactor init_revisions and setup_revisions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 8 Jul 2008, Pierre Habouzit wrote:

> On Tue, Jul 08, 2008 at 10:59:43AM +0000, Johannes Schindelin wrote:
> 
> > On Tue, 8 Jul 2008, Pierre Habouzit wrote:
> > 
> > > setup_revisions has been split in two: parse_revisions that does 
> > > (almost) only argument parsing, to be more like what parse-options 
> > > can do, and setup_revisions that does the rest.
> > 
> > I do not see the sense of this change, except
> 
> Well, it's required to remove "parse_revisions" at once if we one day 
> reach the goal of having only parse-opt based parsers.

We can do that, then.

We do not need to do that, now.

In the meantime, your patch series of already pretty large patches gets 
even larger, which prevents me from being able to review them.

Sad,
Dscho

P.S.: Please do not pull things at me like "it is so convenient to be able 
to drop "0, NULL, " for many sites".  That is not even funny.  This case 
does not need more convenience.  The other cases do.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux