Re: [PATCH 1/6] revisions: refactor init_revisions and setup_revisions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 8 Jul 2008, Pierre Habouzit wrote:

> setup_revisions has been split in two: parse_revisions that does 
> (almost) only argument parsing, to be more like what parse-options can 
> do, and setup_revisions that does the rest.

I do not see the sense of this change, except

- blowing up your patch unnecessarily,
- making it more inconvenient for users, and
- adding an opportunity for bugs to creep in.

In other words, I would like to see the semantics of setup_revisions() 
untouched.

Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux