Re: [PATCH 2/6] revisions: split the pure option parsing out from parse_revisions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 08, 2008 at 10:51:13AM +0000, Johannes Sixt wrote:
> Pierre Habouzit schrieb:
> > +int handle_revision_opt(struct rev_info *revs, int argc, const char **argv,
> > +			int *unkc, const char **unkv)
> > +{
> > +	const char *arg = argv[0];
> > +
> > +	/* pseudo revision arguments */
> > +	if (!strcmp(arg, "--all") || !strcmp(arg, "--branches") ||
> > +	    !strcmp(arg, "--tags") || !strcmp(arg, "--remotes") ||
> > +	    !strcmp(arg, "--reflog") || !strcmp(arg, "--not") ||
> > +	    !strcmp(arg, "--no-walk") || !strcmp(arg, "--do-walk"))
> > +	{
> > +		unkv[*unkc++] = arg;
> 
> +		unkv[(*unkc)++] = arg;

  Huh right. Good catch, I wonder why the testsuite failed to see that.
Anyways I pushed a fix on my public repo.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@xxxxxxxxxx
OOO                                                http://www.madism.org

Attachment: pgpNzhtBhDqFk.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux