Jeff King, Wed, May 21, 2008 16:36:07 +0200: > 2. It's a little hard to see which tests are affected. I would have done > something more like: > > if test "$(git config --bool core.filemode)" = true > test_filemode= > else > test_filemode=: > fi > > $test_filemode test_expect_success ... > > But maybe that is just overengineering. But a nice one. I like the idea but Junio already did your other suggestions in master, so I just keep it in mind for the next one -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html