On Sun, May 18, 2008 at 05:23:37PM +0200, Alex Riesen wrote:
> This is on Cygwin, yes. I have the core.filemode disabled in
> ~/.gitconfig. How about stopping the test before the failing portion
> (only the last two fail, below)?
What's in your ~/.gitconfig shouldn't have any effect (the test scripts
take care to avoid looking at anything outside of your git directory).
But presumably this test is broken on Cygwin, anyway?
I don't mind disabling these tests if they don't make sense on certain
platforms, but regarding your specific proposal:
- can you confirm that the test doesn't make sense, and not that it is
simply broken on cygwin? Does changing your ~/.gitconfig's
core.filemode make a difference? It shouldn't, but that could be
a bug in test-lib. What happens if you run the test manually? Does
git-add just not prompt for the mode change?
- if the tests are to be disabled, I think it is better to
if tests_make_sense; do
tests
fi
rather than exiting the script. It is less error prone if tests get
added later.
- What is the right tests_make_sense? You are checking core.filemode,
but that should not be leaking in from your .gitconfig. Does cygwin
have a different defaults for that value? Is it actually a matter of
being on a filesystem which doesn't properly handle the executable
bit?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
