Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx> --- This is on Cygwin, yes. I have the core.filemode disabled in ~/.gitconfig. How about stopping the test before the failing portion (only the last two fail, below)? $ ./t3701-add-interactive.sh -d -v ... * expecting success: git reset --hard && echo content >>file && chmod +x file && printf "n\\ny\\n" | git add -p && git show :file | grep content && git diff file | grep "new mode" HEAD is now at ddca8ca commit ddca8caf8c92841fca6311cf3ee839dd304f353d -- diff --git a/file b/file index 180b47c..b6f2c08 100644 --- a/file +++ b/file @@ -1 +1,2 @@ baseline +content Stage this hunk [y/n/a/d/?]? * FAIL 9: patch does not affect mode git reset --hard && echo content >>file && chmod +x file && printf "n\\ny\\n" | git add -p && git show :file | grep content && git diff file | grep "new mode" * expecting success: git reset --hard && echo content >>file && chmod +x file && printf "y\\nn\\n" | git add -p && git diff --cached file | grep "new mode" && git diff file | grep "+content" HEAD is now at ddca8ca commit ddca8caf8c92841fca6311cf3ee839dd304f353d -- diff --git a/file b/file index 180b47c..b6f2c08 100644 --- a/file +++ b/file @@ -1 +1,2 @@ baseline +content Stage this hunk [y/n/a/d/?]? * FAIL 10: stage mode but not hunk git reset --hard && echo content >>file && chmod +x file && printf "y\\nn\\n" | git add -p && git diff --cached file | grep "new mode" && git diff file | grep "+content" * failed 2 among 10 test(s) $ t/t3701-add-interactive.sh | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh index f15be93..976ef72 100755 --- a/t/t3701-add-interactive.sh +++ b/t/t3701-add-interactive.sh @@ -66,6 +66,8 @@ test_expect_success 'revert works (commit)' ' grep "unchanged *+3/-0 file" output ' +test "$(git config core.filemode)" = false && test_done + test_expect_success 'patch does not affect mode' ' git reset --hard && echo content >>file && -- 1.5.5.1.354.g902c -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html