Jeff King wrote:
On Sun, May 18, 2008 at 05:23:37PM +0200, Alex Riesen wrote:
This is on Cygwin, yes. I have the core.filemode disabled in
~/.gitconfig. How about stopping the test before the failing portion
(only the last two fail, below)?
What's in your ~/.gitconfig shouldn't have any effect (the test scripts
take care to avoid looking at anything outside of your git directory).
But presumably this test is broken on Cygwin, anyway?
On Cygwin, support for correctly interpreting the execute bit is governed by the
operating system (WindowsNT/XP vs Windows9x), the file system (NTFS vs FAT), and
the (NO)NTEA and (NO)NTSEC options via the CYGWIN environment variable. So,
there is no simple answer... By default on WindowsNT/XP and running on NTFS,
execute modes are supported and the git testsuite currently works.
Some other configurations will not support core.filemode=true, but Cygwin's
stated goal is to emulate Linux and it does so by default using current common
configurations. Thus, disabling the tests unconditionally on Cygwin would be wrong.
Perhaps the better path is to skip the tests if "$(uname -o)" = "Cygwin" and
core.filemode=false, but enable them otherwise, allowing users who know their
configuration will not support the execute bit to avoid the test failure.
Mark
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
